Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework resources don't expose terraform diff in debug logs #340

Open
mbbush opened this issue Feb 2, 2024 · 0 comments
Open

Framework resources don't expose terraform diff in debug logs #340

mbbush opened this issue Feb 2, 2024 · 0 comments
Labels
enhancement New feature or request reconciler v2
Milestone

Comments

@mbbush
Copy link
Contributor

mbbush commented Feb 2, 2024

What problem are you facing?

While working to migrate existing infrastructure into crossplane, I frequently find myself creating managed resources with limited ManagementPolicies, and relying on the debug logs of provider-aws, which log a GoString of the observed diff, to see what changes they are going to make, so I can determine whether the diff is due to drift that I actually want to correct, or a bug in my crossplane manifest. This happens in external_tfpluginsdk.go

For terraform plugin framework resources, when they were reconciled with the CLI, I could accomplish the same thing by execing into the provider pod and running terraform plan. Now that framework resources are reconciled by calling the framework provider directly, this is no longer possible, and the framework client doesn't contain the same debug log statement.

How could Upjet help solve your problem?

Add additional debug logging to the Observe call in the framework client, to log the diff between the spec.forProvider and what is observed. Any format will do, but JSON would be great.

@mbbush mbbush added the enhancement New feature or request label Feb 2, 2024
@jeanduplessis jeanduplessis added this to the 1.2 milestone Feb 3, 2024
@jeanduplessis jeanduplessis modified the milestones: 1.3, 2.x Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reconciler v2
Projects
None yet
Development

No branches or pull requests

2 participants