Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trailing document separator (---) from the generated example manifests #196

Closed
ulucinar opened this issue May 3, 2023 · 0 comments · Fixed by #221
Closed
Assignees
Labels
bug Something isn't working is:triaged

Comments

@ulucinar
Copy link
Collaborator

ulucinar commented May 3, 2023

What happened?

Currently, the generated example manifests have a trailing --- and when folks make a copy of a generated manifest under to the examples directory of a provider and when the up tooling processes it while building a Crossplane package, this may cause issues.

How can we reproduce it?

As an example, please observe the trailing document separator here. Upjet produces the example manifests when configured to do so.

Notes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working is:triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants