Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support group/name input for trace command #4907

Closed
Tracked by #4648
plumbis opened this issue Oct 26, 2023 · 2 comments · Fixed by #4910
Closed
Tracked by #4648

support group/name input for trace command #4907

plumbis opened this issue Oct 26, 2023 · 2 comments · Fixed by #4910
Labels
crossplane-cli enhancement New feature or request
Milestone

Comments

@plumbis
Copy link
Contributor

plumbis commented Oct 26, 2023

What problem are you facing?

Today the crossplane beta trace commands requires group [space] name. It doesn't support / style outputs provided by some Kubernetes outputs like kubectl get claims

How could Crossplane help solve your problem?

Support input of group/name resource like crossplane beta trace cluster.aws.platformref.upbound.io/platform-ref-aws

@plumbis plumbis added the enhancement New feature or request label Oct 26, 2023
@phisco
Copy link
Contributor

phisco commented Oct 26, 2023

I actually implemented it at first and then dropped it because I couldn't come up with a not so confusing help message for the allowed syntaxes 😂 I'll open a pr with the code and ask your help on the help messages.

@plumbis
Copy link
Contributor Author

plumbis commented Oct 26, 2023

I would just leave the help text as is and just accept the input. We can mention in the CLI docs that both inputs are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crossplane-cli enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants