Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing for "comment only" YAML documents in package parser #356

Open
hasheddan opened this issue Sep 26, 2022 · 3 comments
Open
Assignees
Labels
enhancement New feature or request stale

Comments

@hasheddan
Copy link
Member

What problem are you facing?

Currently, the package parser will ignore empty YAML documents and those that only contain whitespace. However, it does not accommodate for a YAML document that contains content which is only comments (which is effectively the same as the previous two document scenarios).

How could Crossplane help solve your problem?

We should consider allowing for "comment only" documents in packages and skipping them during parsing.

@luebken
Copy link

luebken commented Sep 27, 2022

Relevant Yaml spec:
https://yaml.org/spec/1.0/#id2561718

... A document header line may be used to start a document ...

@hasheddan
Copy link
Member Author

@luebken to be clear, this is not due to a leading document header, but rather due to the fact that there is a complete document that only contains comment data. The xpkg specification restricts what can be included in a package. We currently also allow for "empty documents", but a document full of comments is not empty, which is why this scenario results in rejection.

Copy link

github-actions bot commented Sep 3, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants