Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP-Container] Nodepool reconciliation fails when gvisor enabled #491

Open
josephprem opened this issue Feb 8, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@josephprem
Copy link

josephprem commented Feb 8, 2023

What happened?

A nodepool was deleted manually, crossplane tries to reconcile and fails with the message

message: 'create failed: cannot create GKE node pool: googleapi: Error 400:
Node taints with key "sandbox.gke.io/runtime" are managed by GKE and must
not be manually specified., badRequest'
reason: ReconcileError

After deleteing the taints from the live CR object, nodepool was successfully reconciled.

How can we reproduce it?

  1. Create a nodepool with forProvider.config.sandboxConfig.type: gvisor
apiVersion: container.gcp.crossplane.io/v1beta1
kind: NodePool
metadata:
  name: xp-demo-cluster-np
spec:
  forProvider:
    autoscaling:
      autoprovisioned: false
      enabled: true
      maxNodeCount: 5
      minNodeCount: 2 
    clusterRef:
      name: xp-demo-cluster
    config:
      machineType: n1-standard-1
      sandboxConfig:
        type: gvisor
      diskSizeGb: 120
      diskType: pd-ssd
      imageType: cos_containerd
      labels:
        test-label: crossplane-created
      oauthScopes:
      - "https://www.googleapis.com/auth/devstorage.read_only"
      - "https://www.googleapis.com/auth/logging.write"
      - "https://www.googleapis.com/auth/monitoring"
      - "https://www.googleapis.com/auth/servicecontrol"
      - "https://www.googleapis.com/auth/service.management.readonly"
      - "https://www.googleapis.com/auth/trace.append"      
    initialNodeCount: 2
    locations:
      - "us-east4-a"
  providerConfigRef:
    name: my-gcp-config
  1. Delete the nodepool through console or gcloud
  2. Gcp-controller tries to reconcile without success

What environment did it happen in?

Crossplane version: 1.11.0
gcp_provider : crossplane/provider-gcp:master
Deployed on vcluster on a OCP project

@josephprem josephprem added the bug Something isn't working label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant