New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report XR as not ready if required patch failing #152

Open

phisco opened this issue Nov 8, 2024 · 1 comment · May be fixed by #137

Collaborator

phisco commented Nov 8, 2024

crossplane/crossplane#6021 introduced a way for functions to explicitly report XRs as not ready, independently of the Composed resources readiness.

We should leverage that to report the XR as not ready when a required patch on a non-existing composed resource fails due to a missing source, i.e.

function-patch-and-transform/fn.go

Line 235 in c3d4059

if ToComposedResource(p) && !exists {

.

Contributor

MisterMX commented Nov 8, 2024

I think we can reuse #137 for that.

phisco linked a pull request

that will close this issue

fix: Mark composite as unready if resources are skipped #137

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment