Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace build script with rust #786

Merged
merged 2 commits into from
Jun 13, 2022
Merged

replace build script with rust #786

merged 2 commits into from
Jun 13, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner June 13, 2022 00:32
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jun 13, 2022
@Alexhuszagh
Copy link
Contributor

Should this be added to cross-dev?

@Emilgardis
Copy link
Member Author

Should this be added to cross-dev?

what do you mean? it is cross-dev

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 13, 2022 •
edited
Loading

Should this be added to cross-dev?

what do you mean? it is cross-dev

My mistake.

@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #786:
23af727
@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #786:
07768a5
@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #786:
434e7b1
@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build failed:

@Emilgardis Emilgardis mentioned this pull request Jun 13, 2022
Merged
@Emilgardis Emilgardis force-pushed the build-image-rs branch 2 times, most recently from 1d253e9 to 7f335a7 Compare June 13, 2022 01:21
@Emilgardis Emilgardis removed the no changelog A valid PR without changelog (no-changelog) label Jun 13, 2022
@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #786:
ed81054
@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build succeeded:

Alexhuszagh
Alexhuszagh reviewed Jun 13, 2022
View reviewed changes
Cargo.toml Outdated

[dependencies]
atty = "0.2"
clap = { version = "3.1.18", features = ["derive"] }
clap = { version = "3.1.18", features = ["derive", "env"] }
Copy link
Contributor

@Alexhuszagh Alexhuszagh Jun 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of clap 3.2.0 (just released), this produces numerous spurious warnings that are unrelated to the actual code (I believe, see clap-rs/clap#3822) that may cause CI to fail. It might be worth locking clap to =3.1.18 for the meantime.

@Alexhuszagh
Copy link
Contributor

Other than those 2 comments, lgtm.

@Alexhuszagh
Copy link
Contributor

bors try --target aarch64-unknown-linux-gnu

Just testing the clap issues, if it will fail CI.

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors
Try #786: --target aarch64-unknown-linux-gnu
c8a4ac9
@Emilgardis
Copy link
Member Author

we're using --locked, so it shouldn't

@Alexhuszagh
Copy link
Contributor

we're using --locked, so it shouldn't

Ok good, I'll probably submit a PR to fix these CI issues.

@Alexhuszagh Alexhuszagh self-requested a review June 13, 2022 15:40
@Alexhuszagh
Copy link
Contributor

lgtm

bors r+

@Emilgardis
Copy link
Member Author

bors r-

bors bot added a commit that referenced this pull request Jun 13, 2022
@bors @Emilgardis
Merge #786
288ca6d 
786: replace build script with rust r=Alexhuszagh a=Emilgardis



Co-authored-by: Emil Gardström <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

Canceled.

@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member Author

I can add the pin here, no need for separate pr imo.

@Emilgardis Emilgardis force-pushed the build-image-rs branch 2 times, most recently from 18c46d7 to ed2b452 Compare June 13, 2022 15:52
@Emilgardis
Copy link
Member Author

bors r=Alexhuszagh

@bors
Copy link
Contributor

bors bot commented Jun 13, 2022

Build succeeded:

@bors bors bot merged commit ca8145b into cross-rs:main Jun 13, 2022
@Emilgardis Emilgardis deleted the build-image-rs branch June 14, 2022 15:31
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Alexhuszagh