Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenBSD 6.9 and use full sets? #1

Closed
ZhanYF opened this issue Sep 1, 2021 · 4 comments
Closed

Upgrade to OpenBSD 6.9 and use full sets? #1

ZhanYF opened this issue Sep 1, 2021 · 4 comments

Comments

@ZhanYF
Copy link
Contributor

ZhanYF commented Sep 1, 2021

Hi, since 6.9 has been released for a few months and 7.0 is now in beta, I think it would be a good idea to upgrade this builder to the latest version. I did that on my own branch and the result images look good. However I'm unable to test it properly with GitHub action as I'm unable to compile the required Typescript bundle. Could you help me test that?

Apart from that, I believe X11 should not be left out as it is required for building packages, and it can cause problems if the CI environment is different from the official builder's environment.

https://www.openbsd.org/faq/ports/ports.html#PortsIntro

Building ports on systems without X11 is not supported.

Any idea? :)

@jacob-carlborg
Copy link
Contributor

Hi, since 6.9 has been released for a few months and 7.0 is now in beta, I think it would be a good idea to upgrade this builder to the latest version.

That shouldn't be a problem.

However I'm unable to test it properly with GitHub action as I'm unable to compile the required Typescript bundle. Could you help me test that?

Sure. First time contributors need to be approved for the CI pipelines to work. I approved you now so the CI CI pipelines should run now on GitHub.

Apart from that, I believe X11 should not be left out as it is required for building packages, and it can cause problems if the CI environment is different from the official builder's environment.

https://www.openbsd.org/faq/ports/ports.html#PortsIntro

Building ports on systems without X11 is not supported.
Any idea? :)

Hmm, I didn't know about that. I'm new to OpenBSD. I would like to give that some thought.

Anyway, I think this issue needs to be split into two, one for the 6.9 update and one for the X11. We can handle those separately.

This was referenced Sep 1, 2021
@ZhanYF
Copy link
Contributor Author

ZhanYF commented Sep 1, 2021

Done.

I approved you now so the CI pipelines should run now on GitHub.

Seems like it's still pending? Anyway it works fine on my repo, I'm not too worried about that.

@jacob-carlborg
Copy link
Contributor

Seems like it's still pending?

Hmm, the original PR has completed the CI pipeline. I'm not sure about the new ones. Perhaps a PR needs to be merged before a new contributor is approved. I've manually started the CI pipeline on the new PRs.

This was referenced Sep 2, 2021
@jacob-carlborg
Copy link
Contributor

Closing this in favor of #5 and #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants