Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Missing examples of using the cpp sdk (fix #103) #129

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Problem: Missing examples of using the cpp sdk (fix #103) #129

merged 5 commits into from
Jul 13, 2022

Conversation

damoncro
Copy link
Contributor

Solution:

  • Add examples.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest main?
  • Have you checked your code compiles? (cargo build)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (cargo test)
  • Have you checked your code formatting is correct? (cargo fmt -- --check --color=auto)
  • Have you checked your basic code style is fine? (cargo clippy)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (cargo audit)
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@damoncro damoncro marked this pull request as draft June 24, 2022 08:29
leejw51crypto
leejw51crypto reviewed Jun 24, 2022
View reviewed changes
demo/new_wallet.cc Outdated Show resolved Hide resolved
leejw51crypto
leejw51crypto reviewed Jun 24, 2022
View reviewed changes
demo/Makefile Outdated Show resolved Hide resolved
@damoncro damoncro force-pushed the feat/examples branch 5 times, most recently from bfc38be to b83f262 Compare June 29, 2022 06:16
@damoncro
Copy link
Contributor Author

damoncro commented Jun 29, 2022 •
edited
Loading

Added new commit: In linux, the so file links to system's dynamic libraries which are system dependent, and their locations vary between system. Instead, user can build libplay_cpp_sdk.so file from prebuilt libplay_cpp_sdk.a file.

@damoncro damoncro mentioned this pull request Jun 30, 2022
Closed
@leejw51crypto
Copy link
Collaborator

this pr can be too big, how about make into smaller groups.
merged one by one?

@damoncro
Copy link
Contributor Author

ok, I'll try to split them.

@damoncro damoncro force-pushed the feat/examples branch 6 times, most recently from 482ad45 to c4fbf16 Compare July 11, 2022 04:35
@damoncro damoncro requested a review from tomtau July 12, 2022 11:03
@damoncro damoncro marked this pull request as ready for review July 12, 2022 11:03
@tomtau tomtau merged commit 61fa0d7 into cronos-labs:main Jul 13, 2022
@tomtau tomtau mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@tomtau tomtau Awaiting requested review from tomtau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damoncro @leejw51crypto @tomtau