Add Split Library support to ingestor #93
Conversation
This will be used by the ingest processor to save books to the split_dir
Use config_calibre_split_dir if it's set. Save to library path otherwise.
config_calibre_split ended up not being used. CW wasn't using it to determine the save path and I followed their example I've never used python before but I'm seeing that assigning to self.x seems to be idiotmatic.
|
Looks like the author implented these changes in Thanks! |
|
@tucker87 Has this actually worked for you? The changes still cause the book to be added to the wrong folder, plus the book ingest function is broken now due to a misspelled variable name. |
|
I did not test the author's version. I just saw the conflicts when I went to rebase and realized they had done basically the same thing. |
Which variable and error are you referencing? |
I can't see where he implemented the split feature. I'd keep your PR open as a draft for now. |
|
I just merged my PR providing instructions on how to create a development docker container as well! Check the readme, as it's just executing a bash script, then doing This PR would need to be revamped as the python file is completely redone, however it looks like you have 99% of all things needed already. Probably be easier to just create a new branch then add the code there though |
The var name here is wrong: https://github.com/crocodilestick/Calibre-Web-Automated/blob/main/scripts/ingest-processor.py#L182 |
Just fixed it now. Should be pushed to the dev image soon |
|
@MrLemur dev image has been pushed. Use my dev image: |
I can confirm that now fixes the broken import. The original split library issue remains. |
I'm attempting to fix my own issue. But I've never written Python. These edits were made in browser.
I looked at CW's code for handling this and mimicked it.
This is untested.
Would appreciate feedback/help.
Fixes #92