This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Typed wrapping of Js values. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock up generated filed that wrap JS functions.
Add a new annotation to test typed wrappings of JS values. These new wrappers go in the opposite direction than the other ones, and require the generated (.re.js/.tsx) file to call the bucklescript (.bs.js) file. This implies circular dependencies between these two pairs of files. A special category of early requires and exports is reserved to emit all the requires from .re.js/.tsx to .bs.js early. In this way, when these wrappers are used in the .bs.js file, they will have been exported already.
Changed import logic: TS uses import {... as ...}, Flow uses require.
Add a more complex example also involving a conversion of record types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental feature supporting typed wrappers for JS values.
Uses a controlled form of cyclic dependencies between the .bs.js and .re.js/.tsx files.
Generates conversion functions as well as type checking functions with comments indicating where to look in order to resolve type inconsistencies.
A small demo: https://youtu.be/9YeOwMmXGfo