Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to league/flysystem V3 #60

Open
razvanphp opened this issue Apr 28, 2024 · 3 comments
Open

Upgrade to league/flysystem V3 #60

razvanphp opened this issue Apr 28, 2024 · 3 comments

Comments

@razvanphp
Copy link

razvanphp commented Apr 28, 2024

https://flysystem.thephpleague.com/docs/upgrade-from-1.x/
https://flysystem.thephpleague.com/docs/what-is-new/

Can we do this without breaking everything? Would be nice to keep this extension alive.

I can work on the PR, but a little afraid without unit tests....

Thanks!
R

@razvanphp razvanphp changed the title Upgrade to Flysystem V3 Upgrade to league/flysystem V3 Apr 28, 2024
@schmunk42
Copy link
Collaborator

@eluhr @handcode You worked with Flysystem lately, WDYT?

@royalrex
Copy link

royalrex commented May 7, 2024

I'd like to see this happen too - and can help out with a PR.

As I read the code, there is not much to do, other than just update the dependency. All code around flysystem and S3 is external:
https://github.com/creocoder/yii2-flysystem/blob/master/src/AwsS3Filesystem.php#L126

This means, that such a package update will be a breaking change. I wonder if it would be an idea to create a small wrapper that maps the old methods to the new (as described in the upgrade guide) and give deprecation warnings when they are used?

@schmunk42
Copy link
Collaborator

@royalrex @razvanphp PRs welcome, we are not very actively developing this extension anymore to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants