Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Google App Engine authentication #42

Open
razvanphp opened this issue Nov 29, 2019 · 1 comment
Open

Allow Google App Engine authentication #42

razvanphp opened this issue Nov 29, 2019 · 1 comment

Comments

@razvanphp
Copy link

This is similar with PR #40

Documentation of https://github.com/Superbalist/flysystem-google-cloud-storage says:

/**
 * The credentials will be auto-loaded by the Google Cloud Client.
 *
 * 1. The client will first look at the GOOGLE_APPLICATION_CREDENTIALS env var.
 *    You can use ```putenv('GOOGLE_APPLICATION_CREDENTIALS=/path/to/service-account.json');``` to set the location of your credentials file.
 *
 * 2. The client will look for the credentials file at the following paths:
 * - windows: %APPDATA%/gcloud/application_default_credentials.json
 * - others: $HOME/.config/gcloud/application_default_credentials.json
 *
 * If running in Google App Engine, the built-in service account associated with the application will be used.
 * If running in Google Compute Engine, the built-in service account associated with the virtual machine instance will be used.
 */

but in the code keyFilePath is required.

I will prepare a PR for this if nobody beats me to it.

@schmunk42
Copy link
Collaborator

I will prepare a PR for this if nobody beats me to it.

PRs are always welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants