Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskTreap constructor should check for max key length #9

Open
GoogleCodeExporter opened this issue Nov 24, 2015 · 0 comments
Open

DiskTreap constructor should check for max key length #9

GoogleCodeExporter opened this issue Nov 24, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

I think it would be better if the constructor throws an exception if the 
index_block_size is too large (maybe there is a reason for allowing block sizes 
that can accomodate illegal key lengths ? )

What steps will reproduce the problem?
Constructors of the form: DiskTreap<FastString, byte[]>(index_block_size, 
indexFile);

should check the index_block_size-DiskTreapNode.STRING_KEY_OVER_HEAD is not 
greater than 127


Original issue reported on code.google.com by [email protected] on 4 Sep 2011 at 5:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant