Skip to content

Commit

Permalink
Hide PieChart border by default.
Browse files Browse the repository at this point in the history
  • Loading branch information
imaNNeo committed Mar 24, 2021
1 parent 18b10fb commit 634843a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* [IMPROVEMENT] Enabled `sectionsSpace` in PieChart for the web.
* [IMPROVEMENT] Added [Makefile](https://makefiletutorial.com) commands which makes it comfortable for verifying your code before push (It is related to contributors, red more about it in [CONTRIBUTING.md](https://github.com/imaNNeoFighT/fl_chart/blob/master/CONTRIBUTING.md)).
* [BUGFIX] Fixed some bugs on drawing PieChart (for example when we have only one section), #582,
* [BREAKING] Border of pieChart now is hide by default (you can show it using `borderData: FlBorderData(show: true)`.
* [BREAKING] You cannot set `0` value on [PieChartSectionData](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/pie_chart.md#piechartsectiondata).value anymore, instead remove it from list.
* [BREAKING] Removed `fullHeightTouchLine` property from [LineTouchData](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/line_chart.md#linetouchdata-read-about-touch-handling). Now you can have a full line with following snippet:
```dart
Expand Down
5 changes: 4 additions & 1 deletion lib/src/chart/pie_chart/pie_chart_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ class PieChartData extends BaseChartData with EquatableMixin {
sectionsSpace = sectionsSpace ?? 2,
startDegreeOffset = startDegreeOffset ?? 0,
pieTouchData = pieTouchData ?? PieTouchData(),
super(borderData: borderData, touchData: pieTouchData ?? PieTouchData());
super(
borderData: borderData ?? FlBorderData(show: false),
touchData: pieTouchData ?? PieTouchData(),
);

/// Returns true if find any zero value in the list.
static bool _sectionsContainsZero(List<PieChartSectionData>? list) {
Expand Down

0 comments on commit 634843a

Please sign in to comment.