Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported encode language #5

Closed
pieces49 opened this issue Jan 21, 2019 · 10 comments
Closed

Unsupported encode language #5

pieces49 opened this issue Jan 21, 2019 · 10 comments

Comments

@pieces49
Copy link

Hi.

Can you change encode to UTF-8? When I download to PDF my content( wrote by korean ),

it was broken content.

@creecros
Copy link
Owner

it's a font issue. Using DejaVu sans, which is the most universal font that Dompdf comes with, and unfortunately, it does not support Korean.

I will see if I can figure out how to use another font with Dompdf, but Dompdf pretty much sucks, might just look into a different converter.

@creecros
Copy link
Owner

I think I might switch to TCPDF, but it is currently in development of a new deployment, so I will probably wait until that is complete before working on upgrading this plugin. If you know any quick fixes, I would be happy to accept a PR. I tried a few things, that didn't seem to work with dompdf, so for the time being, I probably won't touch this until TCPDF is ready.

https://github.com/tecnickcom/tc-lib-pdf

@kmahyyg
Copy link

kmahyyg commented Apr 5, 2019

Same problem. The fonts not working with CJK Characters. Maybe you could try to generate PDF using another library or change the default fonts?

Plugin Uninstalled.

@creecros
Copy link
Owner

creecros commented Apr 5, 2019

Or I could add a disclaimer that not all characters are supported until I get around to it.

@kmahyyg
Copy link

kmahyyg commented Apr 5, 2019

Why not try to just build a page and pop up, then let user use Chrome print feature to convert it to a PDF?

@creecros
Copy link
Owner

creecros commented Apr 5, 2019

It has more to do with I'm a little busy at the moment
But it is on my list

@creecros
Copy link
Owner

creecros commented Apr 11, 2019

@kmahyyg @pieces49 i stay ed up figuring this one out last night, with some success. i'll have to add an option, where you can select your print language, maybe in the settings, and then i need to find all the fonts for the cjk languages...more to come, but i did manage to get the simplified chinese to work last night.

I couldn't ever get it to work before, because i wasn't considering font-weights.

image

more to come...

@creecros creecros mentioned this issue Apr 12, 2019
@creecros
Copy link
Owner

https://github.com/creecros/Task2pdf/releases/tag/1.1.0

You will have to toggle on support for CJK Chars. Found in Settings > Application, at the bottom.

@kmahyyg
Copy link

kmahyyg commented Apr 12, 2019

Thank you so much

@creecros
Copy link
Owner

no problem, let me know if there are issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants