New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code in README for express server setup issues errors #189

Open

Choongkyu opened this issue Jan 23, 2021 · 1 comment

Choongkyu commented Jan 23, 2021

The code in the README:

app.use(
    '/thrift',
    bodyParser.raw(),
    ThriftServerExpress(Calculator.Processor, serviceHandlers),
)

issues this error:

const serviceHandlers: Calculator.IHandler<express.Request<ParamsDictionary, any, any, QueryString.ParsedQs, Record<string, any>>>
Expected 1 arguments, but got 2.ts(2554)

Also import * as express from 'express' should be import express from 'express', otherwise an error is issued.

The text was updated successfully, but these errors were encountered:

Ivan-Parushev commented Jun 14, 2021 •

edited

Loading

I've got the same error. It seems that the code in the readme is not up-to-date. You look here to find you answers https://github.com/creditkarma/thrift-server/tree/master/packages/thrift-server-express

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment