New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import error for "thrift" in generated Typescript with thrift 0.13.0, 0.12.0 is OK. #188

Open

mfickett opened this issue Aug 18, 2020 · 0 comments

mfickett commented Aug 18, 2020

To reproduce this issue:

Check out https://github.com/angelomelonas/thrift-spring-boot-vue-chat/tree/7f9423ff04e666096209f9aa86680bf5b37c483e
npm install and npm run serve => compiles and launches OK
Get the latest thrift-typescript: edit package.json to have "@creditkarma/thrift-typescript": "^3.7.6" (everything still works)

Then:

Upgrade the thrift dependency: edit package.json to have "thrift": "0.13.0"
npm install and npm run serve

Expected: Still works
Observed:

This dependency was not found:

* thrift in ./codegen/Message.ts, ./codegen/ChatService.ts and 5 others

To install it, you can run: npm install --save thrift

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment