Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use enums from other files in map constants #173

Open
hayes opened this issue Sep 14, 2019 · 4 comments · May be fixed by #174
Open

Can't use enums from other files in map constants #173

hayes opened this issue Sep 14, 2019 · 4 comments · May be fixed by #174

Comments

@hayes
Copy link
Contributor

hayes commented Sep 14, 2019

The following produces an error, but should be valid:

keys.thrift

namespace js example
enum Keys {
  foo = 1,
  bar = 2,
}

map.thrift

namespace js example
include './keys.thrift'

const map<keys.Keys, string>  MyMap = {
  keys.Keys.foo: "foo",
  keys.Keys.bar: "bar",
}

Error: Unable to resolve value of identifier[keys.Keys.foo]

@hayes hayes linked a pull request Sep 14, 2019 that will close this issue
@hc-danieltiziani
Copy link

Any change to get this PR merged? I'm facing the same issue here:

(node:88856) UnhandledPromiseRejectionWarning: Error: Unable to resolve identifier[FeeType] in xxx/xxx/xxx

@thonythony
Copy link

Same problem here, why this PR is not yet merged after two years ?

@hayes
Copy link
Contributor Author

hayes commented Jun 3, 2021

🤷 I know a couple of other small things got addressed since I put this up, but the repo has been pretty in-active for a while. We ended up creating a fork at Airbnb since there were several issues we couldn't get any progress on (I don't work there anymore).

@niodice
Copy link

niodice commented Jul 20, 2023

Also curious about the feasibility of merging this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants