Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating code on windows, generated import paths uses Windows path separators #169

Open
mthurlin opened this issue Jul 23, 2019 · 0 comments

Comments

@mthurlin
Copy link

When generating code on Windows, import paths ends up with Windows path separators:
import * as com_foo_core_thrift from "./..\\..\\..\\..\\core\\thrift";.

This works in Windows, but breaks for anyone trying to run the code somewhere else.

If it was normalized to import * as com_foo_core_thrift from "./../../../../core/thrift"; it would work everywhere.

I guess this is the culprit:
https://github.com/creditkarma/thrift-typescript/blob/master/src/main/render/shared/includes.ts#L223-L231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant