fix: methodParams should be optional

creditkarma · May 24, 2019 · 9f39218 · 9f39218
1 parent f9509f3
commit 9f39218
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 12 deletions.
diff --git a/src/main/render/thrift-server/service/utils.ts b/src/main/render/thrift-server/service/utils.ts
@@ -224,7 +224,7 @@ export function renderMethodParametersProperty(): ts.PropertyDeclaration {
             ts.createToken(ts.SyntaxKind.ReadonlyKeyword),
         ],
         COMMON_IDENTIFIERS._methodParameters,
-        undefined,
+        ts.createToken(ts.SyntaxKind.QuestionToken),
         methodParamMapType,
         COMMON_IDENTIFIERS.methodParameters,
     )

diff --git a/src/tests/unit/fixtures/thrift-server/annotations_service.solution.ts b/src/tests/unit/fixtures/thrift-server/annotations_service.solution.ts
@@ -600,7 +600,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public getUser(id: number, context?: Context): Promise<IUser> {

diff --git a/src/tests/unit/fixtures/thrift-server/basic_service.solution.ts b/src/tests/unit/fixtures/thrift-server/basic_service.solution.ts
@@ -588,7 +588,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public getUser(id: number, context?: Context): Promise<IUser> {

diff --git a/src/tests/unit/fixtures/thrift-server/basic_service.strict_union.solution.ts b/src/tests/unit/fixtures/thrift-server/basic_service.strict_union.solution.ts
@@ -471,7 +471,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public getUser(arg1: MyUnionArgs, context?: Context): Promise<string> {

diff --git a/src/tests/unit/fixtures/thrift-server/generated-strict/SharedService.ts b/src/tests/unit/fixtures/thrift-server/generated-strict/SharedService.ts
@@ -496,7 +496,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public getStruct(key: number, context?: Context): Promise<__NAMESPACE__.ISharedStruct> {

diff --git a/src/tests/unit/fixtures/thrift-server/generated-strict/com/test/calculator/Calculator.ts b/src/tests/unit/fixtures/thrift-server/generated-strict/com/test/calculator/Calculator.ts
@@ -2577,7 +2577,7 @@ export class Client<Context = any> extends __ROOT_NAMESPACE__.SharedService.Clie
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     constructor(connection: thrift.IThriftConnection<Context>) {

diff --git a/src/tests/unit/fixtures/thrift-server/generated/SharedService.ts b/src/tests/unit/fixtures/thrift-server/generated/SharedService.ts
@@ -496,7 +496,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public getStruct(key: number, context?: Context): Promise<__NAMESPACE__.ISharedStruct> {

diff --git a/src/tests/unit/fixtures/thrift-server/generated/com/test/calculator/Calculator.ts b/src/tests/unit/fixtures/thrift-server/generated/com/test/calculator/Calculator.ts
@@ -2577,7 +2577,7 @@ export class Client<Context = any> extends __ROOT_NAMESPACE__.SharedService.Clie
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     constructor(connection: thrift.IThriftConnection<Context>) {

diff --git a/src/tests/unit/fixtures/thrift-server/i64_service.solution.ts b/src/tests/unit/fixtures/thrift-server/i64_service.solution.ts
@@ -422,7 +422,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public peg(name: string, context?: Context): Promise<string> {

diff --git a/src/tests/unit/fixtures/thrift-server/resolved_field_service.solution.ts b/src/tests/unit/fixtures/thrift-server/resolved_field_service.solution.ts
@@ -178,7 +178,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public ping(id: number | string | thrift.Int64, context?: Context): Promise<void> {

diff --git a/src/tests/unit/fixtures/thrift-server/throws_multi_service.solution.ts b/src/tests/unit/fixtures/thrift-server/throws_multi_service.solution.ts
@@ -509,7 +509,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public peg(name: string, context?: Context): Promise<string> {

diff --git a/src/tests/unit/fixtures/thrift-server/throws_service.solution.ts b/src/tests/unit/fixtures/thrift-server/throws_service.solution.ts
@@ -445,7 +445,7 @@ export class Client<Context = any> extends thrift.ThriftClient<Context> {
     public readonly _annotations: thrift.IThriftAnnotations = annotations;
     public readonly _methodAnnotations: thrift.IMethodAnnotations = methodAnnotations;
     public readonly _methodNames: Array<string> = methodNames;
-    public readonly _methodParameters: {
+    public readonly _methodParameters?: {
         [methodName: string]: number;
     } = methodParameters;
     public peg(name: string, context?: Context): Promise<string> {