You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have some great patterns with Plugins to extend Vault Behaviour and Factories to create different vault types. However, we are sharing the same VaultParams across all Vaults and Plugin types. This means the VaultParams will grow forever. :)
Let's split this VaultParams up, and push the logic into the VaultFactories. For example:
This is likely a large refactoring across contracts, api, sdk and scripts. So, suggest we keep this in mind, but not start on it without improving our test cover and merge our scripts and sdk.
The text was updated successfully, but these errors were encountered:
https://github.com/credbull/credbull-defi/blob/8a910043673f8c3e5d7f68f6e5e496e138806786/packages/contracts/src/interface/ICredbull.sol#L12C1-L28C6
We have some great patterns with Plugins to extend Vault Behaviour and Factories to create different vault types. However, we are sharing the same VaultParams across all Vaults and Plugin types. This means the VaultParams will grow forever. :)
Let's split this VaultParams up, and push the logic into the VaultFactories. For example:
BaseVault only really needs the following:
Adding a WindowPlugin we need to also provide:
This is likely a large refactoring across contracts, api, sdk and scripts. So, suggest we keep this in mind, but not start on it without improving our test cover and merge our scripts and sdk.
The text was updated successfully, but these errors were encountered: