Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliders feature #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sliders feature #2

wants to merge 1 commit into from

Conversation

johnekj
Copy link

@johnekj johnekj commented Jan 8, 2020

This adds sliders feature:

  • slider widget using GUI or code: {{widget type="Creatuity\OptimumImages\Block\Widget\Slider" slider_key="home"}}
  • slider management in Admin
  • assigning images to sliders

@krzysztof-pich
Copy link

@johnekj Is it desired for sliders to be part of image optimizer? In my opinion separate module for sliders with require in composer for creatuity/magento2-optimumimages will be better. This way image optimizer will be responsible for optimizing images and slider module will be responsible for sliders instead of one module to rule all image related things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants