Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent text overflow in card titles on smaller screens #833

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix: prevent text overflow in card titles on smaller screens #833

merged 2 commits into from
Oct 21, 2024

Conversation

MohdMuslim92
Copy link
Contributor

Fixes

Description

This pull request addresses a bug where card titles overflowed on smaller screen sizes. It adds a CSS rule to ensure that text within .card-title wraps properly, preventing it from extending beyond the card's boundaries.

Technical details

  • Added word-wrap: break-word; to the .card-title class in project-ideas.scss to handle long text.
  • This change ensures better readability and a more responsive design, especially on mobile devices.

Tests

  1. Navigate to the issue finder page.
  2. Resize the window to a smaller screen size.
  3. Verify that long card titles no longer overflow and are wrapped properly within their containers.

Screenshots

before

before

after

after

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@MohdMuslim92
Fix: ensure card titles wrap text properly in issue finder page
2e4605e 
- Added CSS rule to `.card-title` to apply `word-wrap: break-word` for better text wrapping.
- This prevents long text from overflowing, ensuring it stays within the container.
@MohdMuslim92 MohdMuslim92 requested review from a team as code owners October 17, 2024 21:45
@MohdMuslim92 MohdMuslim92 requested review from TimidRobot, Shafiya-Heena and akmadian and removed request for a team October 17, 2024 21:45
TimidRobot
TimidRobot approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@TimidRobot TimidRobot merged commit 7628c37 into creativecommons:main Oct 21, 2024
1 check passed
@TimidRobot TimidRobot self-assigned this Oct 21, 2024
@MohdMuslim92
Copy link
Contributor Author

@TimidRobot Thanks for your time and appreciated guidance through all communication channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@akmadian akmadian Awaiting requested review from akmadian akmadian is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

Assignees

@TimidRobot TimidRobot

Labels
None yet
Projects
Applications
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Text Overflow on Smaller Screen sizes
2 participants
@MohdMuslim92 @TimidRobot