Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] The need to require a Node.js version is not specified in JavaScript Guidelines #666

Open
1 task
possumbilities opened this issue Sep 16, 2022 · 4 comments
Labels
📖 aspect: docs Concerns the documentation in the repository ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Sep 16, 2022

Problem

Currently there is not a consistent method across repositories for requiring a minimum Node.js version. This can and will create issues for contributing to repositories.

Description

This can be solved by adding guidance in the Javascript Guidelines to add:

"engines" : { "npm" : ">=x.y.z","node" : ">=x.yz"} to the package.json file as a baseline standard

Alternatives

Additionally, you can edit the .npmrc file to contain:

# .npmrc
engine-strict=true

but this provides inconsistent behavior, as local devs may have their own pre-existing .npmrc file.

A .nvmrc route is also possible and might have better outcomes

Additional context

Implementation

  • I would be interested in implementing this feature.
@possumbilities possumbilities added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Sep 16, 2022
@456535688765

This comment was marked as outdated.

@TimidRobot TimidRobot added help wanted Open to participation from the community 🏁 status: ready for work Ready for work 📖 aspect: docs Concerns the documentation in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Sep 17, 2024
@osujipius
Copy link

@TimidRobot Can I work on this?

@TimidRobot
Copy link
Member

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs.

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

For work program applicants, each can all list their own PRs on their application. It is the quality of work that is important, not whether it is merged.

@Srayash
Copy link

Srayash commented Oct 18, 2024

@possumbilities does this issue require changing package.json in all the directories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 aspect: docs Concerns the documentation in the repository ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

No branches or pull requests

5 participants