Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails default code is false #1083

Closed
satou-haruka-37 opened this issue Aug 23, 2024 · 2 comments
Closed

Rails default code is false #1083

satou-haruka-37 opened this issue Aug 23, 2024 · 2 comments

Comments

@satou-haruka-37
Copy link

satou-haruka-37 commented Aug 23, 2024

The part that was not recognized as a typo until yesterday,
will be recognized as an error from today on.

Below is the GitHub Actions execution log.
Saving to: ‘typos-v1.23.7-x86_64-unknown-linux-musl.tar.gz’

     0K ........ ........ ........ ........ ........ ........ 55% 82.4M 0s
  [30](https://github.com/company/app_name/actions/runs/00000000/job/0000000#step:3:32)72K ........ ........ ........ ........ .....            100%  306M=0.04s

2024-08-23 06:23:36 (122 MB/s) - ‘typos-v1.23.7-x86_64-unknown-linux-musl.tar.gz’ saved [5630851/5630851]

./typos
jq: jq-1.6
$ ./typos .
Warning: "goes" should be "ges".
Warning: "Prepend" should be "Perpend".
error: `goes` should be `ges`
  --> ./config/application.rb:[31](https://github.com/company/app_name/actions/runs/00000000/job/0000000#step:3:33):64
   |
31 |     # Configuration for the application, engines, and railties goes here.
   |                                                                ^^^^
   |
error: `Prepend` should be `Perpend`
  --> ./config/environments/production.rb:51:5
   |
51 |   # Prepend all log lines with the following tags.
   |     ^^^^^^^
   |
Error: Process completed with exit code 2.
My GitHub Actions configuration file looks like this.
name: Check Typos
on: [pull_request]

jobs:
  run:
    name: Spell Check with Typos
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Actions Repository
        uses: actions/checkout@v3

      - name: Run Typos
        uses: crate-ci/typos@master
@epage
Copy link
Collaborator

epage commented Aug 23, 2024

You must have locale = "en-us" enabled. That was broken until yesterday with #1082. To cut down on questionable results from that, we filtered out some entries today in #1086. Both of the typos you reported are no longer reported so I'm going to close this. If there is something I'm missed in this and we need to re-open, let us know!

@epage epage closed this as completed Aug 23, 2024
@satou-haruka-37
Copy link
Author

@epage
Thank you so very much ! 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants