Skip to content

Commit

Permalink
Remove TEXT output from MV_APPEND
Browse files Browse the repository at this point in the history
  • Loading branch information
craigtaverner committed Oct 23, 2024
1 parent 84e045e commit ab13bba
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/esql/functions/types/mv_append.asciidoc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public class MvAppend extends EsqlScalarFunction implements EvaluatorMapper {
"ip",
"keyword",
"long",
"text",
"version" },
description = "Concatenates values of two multi-value fields."
)
Expand Down Expand Up @@ -134,12 +133,12 @@ protected TypeResolution resolveType() {
if (resolution.unresolved()) {
return resolution;
}
dataType = field1.dataType();
dataType = field1.dataType().noText();
if (dataType == DataType.NULL) {
dataType = field2.dataType();
dataType = field2.dataType().noText();
return isType(field2, DataType::isRepresentable, sourceText(), SECOND, "representable");
}
return isType(field2, t -> t == dataType, sourceText(), SECOND, dataType.typeName());
return isType(field2, t -> t.noText() == dataType, sourceText(), SECOND, dataType.typeName());
}

@Override
Expand Down

0 comments on commit ab13bba

Please sign in to comment.