Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPP changes #6

Open
siberian1967 opened this issue Dec 21, 2020 · 4 comments
Open

CPP changes #6

siberian1967 opened this issue Dec 21, 2020 · 4 comments

Comments

@siberian1967
Copy link

I have made just enough modifications to get a cpp version of this library so that it compiles under Arduino inside VSCode. The only change left for me to make is to properly handle the gpio_pull_mode_t assignment (I have it hardcoded to PULLUP for my environment).

Are you interested in an Arduino compat CPP file or should I just fork the repo?

Tx!
@lukecyca
Copy link
Contributor

lukecyca commented Jan 6, 2021

If the repo continues to work as a component for esp_idf, then what you propose sounds fine to me.

Feel free to submit a PR.

@larsenpedersen
Copy link

@siberian1967 Did you ever do this PR?

@W-M-D
Copy link

W-M-D commented Oct 30, 2021

yeah this doesn't work at all with c++ please for it :)

@lukecyca
Copy link
Contributor

This may be fixed with #11. Can anyone confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukecyca @siberian1967 @larsenpedersen @W-M-D