Add asset indexing to Craft cli.

[ryanpcmcquen]

Closes #2980.

[ryanpcmcquen]

I actually think the default should be false (0) on $cacheImages here, but since the GUI default is true, I made the default true here as well. I'm guessing a lot of people don't want to fill their database (host volume) with an image they are already storing somewhere else (like on an S3 bucket).

But, that discussion/decision shouldn't be tied to this PR anyway.

[brandonkelly]

They get stored in the storage/ folder, not your database, and it’s a prerequisite to generating new image transforms, so a reasonable argument could be made either way.

[andris-sevcenko]

Sorry for the delayed response - thinks have been a tad hectic lately.

Can you, please, reuse the same indexing session id for one indexing session instead of generating a new one for every file that is getting indexed?

[ryanpcmcquen]

@andris-sevcenko, thank you for reviewing this! How would you recommend doing that? Can it just use a timestamp?

[andris-sevcenko]

@ryanpcmcquen you should call the Craft::$app->getAssetIndexer()->getIndexingSessionId() method once per session and use the returned value for all actual indexing calls.

Also, the docblock above the class definition does not look like anything that Craft has. (starting here)

[ryanpcmcquen]

@andris-sevcenko, isn't this similar?
https://github.com/craftcms/cms/blob/3.1/src/console/controllers/MigrateController.php#L24

I changed it to use the session id as requested. 🎉

[andris-sevcenko]

@ryanpcmcquen You are correct. It is similar. I guess there was a precedent, after all but I failed to find it :)

[ryanpcmcquen]

@andris-sevcenko, I will restore it then! Anything else?

[ryanpcmcquen]

@andris-sevcenko, I restored the docblock, any other comments on the PR?

[andris-sevcenko]

@ryanpcmcquen ah sorry, totally forgot about this one today - it was on my list, too :/

I'll take care of this tomorrow my time, sorry for the delay!

[andris-sevcenko]

Thank you for your patience, Ryan. You have been more than awesome!

[ryanpcmcquen]

Thank you Andris!

[khalwat]

Wow, thank you @ryanpcmcquen -- saved me from writing it!

[ryanpcmcquen]

@brandonkelly, should I have set the @author in the docblock? Wasn't sure what the policy was here ...

[brandonkelly]

@ryanpcmcquen Ah yeah I overlooked that too. Added for the next release.