Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing tags are not suggested anymore #3676

Closed
boboldehampsink opened this issue Jan 21, 2019 · 5 comments
Closed

Existing tags are not suggested anymore #3676

boboldehampsink opened this issue Jan 21, 2019 · 5 comments

Comments

@boboldehampsink
Copy link
Contributor

Description

When adding a tag it should suggest existing tags in the autocompleter. It doesn't do that anymore, and always offers to add a new tag.

Steps to reproduce

  1. Add a tag group and add a tag field to an element
  2. Add a tag, then add that same tag again
  3. Expected: re-use the tag
  4. Result: new tag

Additional info

  • Craft version: 3.0.37
  • PHP version: 7.3.1
  • Database driver & version: PostgreSQL 10.6
  • Plugins & versions: N/A
@brandonkelly
Copy link
Member

Add a tag, then add that same tag again

As in you’re trying to add the same tag to the same field?

That’s explicitly disallowed, and has been since the Tags field was first written.

0a9ff80#diff-1b2161c927879802b1e09ac06216e819R116

@boboldehampsink
Copy link
Contributor Author

Yeah it should be disallowed. In stead, I can add it again (it creates a new one). What I expect is that it autosuggests the already existing tag to me.

@boboldehampsink
Copy link
Contributor Author

Here is a screenshot
screen shot 2019-01-21 at 14 54 40

@brandonkelly
Copy link
Member

It shouldn’t be possible to select duplicate tags either. So as of the next release it will show all tag matches, but disable them if they’re already selected.

screen shot 2019-01-21 at 6 36 40 am

@boboldehampsink
Copy link
Contributor Author

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants