Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow symfony/*:^4.0 packages #2707

Closed
ostark opened this issue Apr 7, 2018 · 2 comments
Closed

Allow symfony/*:^4.0 packages #2707

ostark opened this issue Apr 7, 2018 · 2 comments

Comments

@ostark
Copy link
Contributor

ostark commented Apr 7, 2018 •
edited
Loading

Description

Craft does not support Plugins with symfony/*:^4.0 dependencies, as it depends on composer/composer:~1.5.2 and this package depends on:

        "symfony/console": "^2.7 || ^3.0",
        "symfony/finder": "^2.7 || ^3.0",
        "symfony/process": "^2.7 || ^3.0",
        "symfony/filesystem": "^2.7 || ^3.0",

In composer/composer:1.6. they opened the version constraint to ^4.0:
composer/composer@3a491a9#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780

AFAIK it's safe to upgrade as there are no API changes from 3.4 to 4.0. I tried it locally without any issues.
@brandonkelly
Copy link
Member

If anyone’s going to follow SemVer it’ll be Composer :)

@ostark
Copy link
Contributor Author

ostark commented Apr 9, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @ostark