[4.x]: Revision Notes not working

[olsp]

What happened?

I tried to use the revision notes for entries but everytime I change field value, write something in the revision note field and save, the text in the revision notes are gone.

In my template I already prepared the code to display the notes on the frontend like this {{ entry.revisionNotes }}, but then I get an error: "Invalid Call – yii\base\InvalidCallException Getting write-only property: craft\elements\Entry::revisionNotes"

Are the revision notes not meant to be used like this?

Craft CMS version

4.3.6.1

PHP version

8.0.14

[brianjhanson]

Thanks for reporting! At the moment revisionNotes are protected which means you can't access them with other entry properties. We may end up making those more public (potentially in the process of implementing #12610). If you need to get at them in the meantime, you are able to access them the same way we do for the entry table.

{% set revision = entry.currentRevision %}  
{% if revision %}  
    {% set behavior = revision.getBehavior('revision') %}  
    {% if behavior %}  
        {{ behavior.revisionNotes }}  
    {% endif %}  
{% endif %}

[brandonkelly]

I tried to use the revision notes for entries but everytime I change field value, write something in the revision note field and save, the text in the revision notes are gone.

This should be fixed now, in Craft 4.3.8. Revision notes that were set on the input weren’t being retained when you reloaded the entry edit page.

[olsp]

Thanks for looking into this. I updated to 4.3.8 and now the revision notes are saved while an entry is a draft but as soon as I save the entry, the revision notes are gone. When writing a new revision note for a published entry, they disappear as soon as I save the entry.

[brandonkelly]

The current revision’s notes should show up within the meta info, below the editable note input:

[olsp]

Am I doing something wrong? They don't show up for me.

[brianjhanson]

Very odd. I'm not seeing the same behavior on a clean install. Is there anything in storage/logs that might provide a clue? Or do you have any non-default configuration settings set?

[brandonkelly]

@olsp Does your section have versioning enabled?

[olsp]

Yes, I do see versions. I just created a new version with a revision note. When I switch to the previous version, I do see the "old" revision note. So it seems like the only the current revision note isn't visible.

[olsp]

@brianjhanson here is what I have added to the config:

'limitAutoSlugsToAscii' => true,
'convertFilenamesToAscii' => true,
'maxUploadFileSize' => 335544320,
'maxRevisions' => 0,
'sendPoweredByHeader' => false,
'postLoginRedirect' => 'dashboard',
'setPasswordRequestPath' => 'reset-password'

I don't really know what to look for in the logs. Do you have a hint what to look into?

[brianjhanson]

Can you send over a database dump, composer.lock and composer.json files to [email protected], and we can dig in a bit more?

[brandonkelly]

All fixed for the next Craft 3 and 4 releases, via #12661. Thanks for bearing with us @olsp!

[brandonkelly]

Craft 3.7.66 and 4.3.9 are out with that fix!