Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punycode Dependency Abandoned #11948

Closed
bencroker opened this issue Sep 15, 2022 · 4 comments
Closed

Punycode Dependency Abandoned #11948

bencroker opened this issue Sep 15, 2022 · 4 comments
Assignees

Comments

@bencroker
Copy link
Contributor

bencroker commented Sep 15, 2022

What happened?

The Punycode package required in composer.json is now abandoned.

"true/punycode": "^2.1.1",

Screenshot 2022-09-15 at 11 31 57

I don't see any usage of in the codebase so perhaps it makes sense to remove it as a dependency? In case the functionality is indeed used or required, Symfony Polyfill / Intl: Idn provides the same functionality.

This applies to both Craft 3 and 4.

@bencroker bencroker changed the title [4.x]: Punycode Dependency Abandoned Punycode Dependency Abandoned Sep 15, 2022
@brandonkelly
Copy link
Member

@angrybrad Looks like it was added in 455051f, but nothing is actually referencing it. Any idea?

@angrybrad
Copy link
Member

@brandonkelly it's 100% legacy on Craft 4 since we require the intl extension and I'm 99.9% sure it's pointless on Craft 3, too.

@brandonkelly
Copy link
Member

Alright, removed for the next releases.

@brandonkelly
Copy link
Member

Craft 3.7.55 and 4.2.5 are out with Punycode removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants