Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: #11930

Closed
djrees opened this issue Sep 13, 2022 · 3 comments
Closed

[4.x]: #11930

djrees opened this issue Sep 13, 2022 · 3 comments

Comments

@djrees
Copy link

djrees commented Sep 13, 2022

What happened?

Description

When using Safari or Chrome on macOS with a British keyboard layout, the password input on the main Craft CMS login screen has an unexpected behaviour when trying to enter a password with an '#' or '€' character.

On a macOS with a British keyboard layout, the '#' character is created by typing 'alt+3' and '€' via 'alt+2'. However, when you press the alt key on the password input, it quickly reveals your plain text password.

If you're password contains one of these characters and you're entering your password quickly, pressing alt+3 can often replace the entire password with a single '#' or puts the '#' at the start of the password.

This does not happen in Firefox.

Steps to reproduce

  1. Goto the login page of a CraftCMS 3 or 4 instance
  2. Type in the password: 'pass#word'.
  3. Get frustrated.

Expected behavior

The password field should not be using the alt key for password revealing the plain text version

Actual behavior

Password field uses the alt key to reveal the password and causes issues whilst typing '#' or '€' on macOS British keyboard layout

Craft CMS version

3 & 4

PHP version

No response

Operating system and version

macOS 12.5.1

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@brandonkelly
Copy link
Member

That’s a good point, thanks for reporting that! I just removed the Alt press behavior for the next Craft 3 and 4 releases.

@brandonkelly
Copy link
Member

Craft 3.7.54 and 4.2.4 are now tagged with that change.

@djrees
Copy link
Author

djrees commented Sep 14, 2022

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants