Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code injection vulnerability on /system/log endpoint #120

Open
pondzikk opened this issue Apr 14, 2024 · 0 comments
Open

Code injection vulnerability on /system/log endpoint #120

pondzikk opened this issue Apr 14, 2024 · 0 comments

Comments

@pondzikk
Copy link

craftbeerpi4/cbpi/controller/system_controller.py

Line 61 in 988f19e

os.system('journalctl --since \"{} hours ago\" -u craftbeerpi.service > {}'.format(logtime, fullname))

URL GET parameter {logtime} utilized within the downloadlog function from cbpi/http_endpoints/http_system.py is subsequently passed to the os.system function in cbpi/controller/system_controller.py without prior validation allowing to execute arbitrary code.

Vulnerability exists from 4.0.0.58 version (563fae9 commit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pondzikk