Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "OpenEXR" package #128

Closed
hjmallon opened this issue Jan 10, 2020 · 6 comments
Closed

Add "OpenEXR" package #128

hjmallon opened this issue Jan 10, 2020 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@hjmallon
Copy link

hjmallon commented Jan 10, 2020

Here is the package request from old hunter https://github.com/ruslo/hunter/issues/361


I have already got this working in a test branch (thanks to the great work done upstream in improving their CMake build system recently). I have 3 PRs open upstream taken from my hunterize-2 branch.

I will need a fork in hunter-packages to add the hunter_add_package and HunterGate on top of those commits (which hopefully will be absorbed upstream).

@hjmallon hjmallon added the help wanted Extra attention is needed label Jan 10, 2020
@rbsheth
Copy link
Member

rbsheth commented Jan 13, 2020

@hjmallon Thanks for getting some PRs upstream! I made a fork here: https://github.com/cpp-pm/openexr

@hjmallon
Copy link
Author

cpp-pm/openexr#1

Added hunterization PR to that fork.

@hjmallon
Copy link
Author

hjmallon commented Jan 15, 2020

Note to self, tasks required:

  • Merge hunterisation here 2.4.0-p0 Hunterize OpenEXR 2.4.0 openexr#1
  • Make PR based on that. pr.IlmBase for IlmBase
  • Wait for release with IlmBase
  • Add testing PR for IlmBase
  • Make v2.4.0-p1 with a Hunter release including IlmBase
  • Make PR based on that pr.OpenEXR which also includes pointing IlmBase at version 2.4.0-p1
  • Wait for release with OpenEXR and IlmBase
  • Add testing PR for OpenEXR

Adding packages with 2 dependant packages inside them is a little complicated as the hunterisation of a package includes a link to a version of hunter that itself supports building part of the package...

@rbsheth
Copy link
Member

rbsheth commented Jan 15, 2020

@hjmallon It would be nice to split IlmBase out but that will be a nightmare to maintain, so I'm okay with your proposed steps.

@hjmallon
Copy link
Author

hjmallon commented Mar 2, 2020

@hjmallon It would be nice to split IlmBase out but that will be a nightmare to maintain, so I'm okay with your proposed steps.

Quote from @cary-ilm

Our intention with the 3.0 release later in the year is to split these projects into separate github repos, creating proper dependencies between them, which will mean an entire re-vamp of the cmake setup.

As mentioned here AcademySoftwareFoundation/openexr#639 the OpenEXR are planning to split IlmBase and OpenEXR in a v3.0.0 release this year anyway. So the weird dependency will be sorted then.

@rbsheth
Copy link
Member

rbsheth commented Mar 6, 2020

@hjmallon Closing as #138 and #164 have been merged

@rbsheth rbsheth closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants