Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Emotes #207

Open
andy013 opened this issue Sep 12, 2017 · 44 comments
Open

Request Emotes #207

andy013 opened this issue Sep 12, 2017 · 44 comments
Labels
Living document Long-term issues intended to be continually edited

Comments

@andy013
Copy link
Contributor

andy013 commented Sep 12, 2017

Want an emote for the site but don't see it in this list?

request one in the comments and if it gets enough support we would love to add it! (assuming it is not nsfw...)

@NukertSH
Copy link

hehe, i like it

@DennisTheFinn
Copy link
Contributor

DennisTheFinn commented Sep 12, 2017

so like the emotes we currently have on our discord? https://discord.gg/wCfXkMd

-- I don't however like the idea of getting rid of claims panel... but it could be updated to include the card emotes...

@DennisTheFinn DennisTheFinn added the suggested enhancement Unapproved issues that could improve site features label Sep 12, 2017
@DennisTheFinn
Copy link
Contributor

I think this would be a great benefit that you would have to earn, where you cant access the emoji's right away, you have to get rainbow or something

@andy013
Copy link
Contributor Author

andy013 commented Sep 14, 2017

I worked on a bunch more and cleaned up the ones from before so they look better on a dark grey background.

Check em out:
JaCard =
NeinCard =
FasSkull =
FasSkull2 =
LibBird =
LibBird2=
Ja =
Nein =

Not sure which version of the policies is best, I think I like the first lot with the large letters:
FasPolicy =
LibPolicy =
FasPolicy2 =
LibPolicy2=
FasPolicy3 =
LibPolicy3 =

Hitler =
Fas2 =
Fas0 =
Fas0_2 =
FasGrin =
FasGrin2 =
Lib3 =
Lib3_2 =
RedFace =
LibStare =
LibStare2 =
Lib5Zoom =
Lib5 =
LibSmile =
SillyLib =
BangBang =
Skull =
NotHilter =
TopDeck =
PDraw3 =
PBullet =
PInvest =
PPres =
FasGlory =
LibGlory =
FasGoofy =
FasFrog =
FasCroc =

I thought it would be fun if you could add twitch.tv style emotes to the chat. If you're not familiar they are small 28x28 images that are displayed in place of a unique case sensitive string.

For example:
CardNein = VoteNein
CardJa = CardYa
VoteJa = VoteYa
VoteNein = VoteNein
LogoFas = LogoFas
LogoLib = LogoLib
FasSkull = FasSkull
LibBird = LibBird
RoleLib = RoleLib
RoleFas =RoleFas
SecretHilter = SecretHitler

I'm not very good with photoshop but I just quickly resized these images to see what they would look like and I think it would be a cool little feature to add. Perhaps you could add some for the cards as well and then get rid of the claims panel and just use emotes instead. That way people can reclaim later if that is part of their strategy. You could also have unique emotes that you can unlock by playing a certain number of games or winning tournaments etc. Also having tab auto complete for the strings would be very convenient.

@DennisTheFinn
Copy link
Contributor

it says 'not hilter'

@andy013
Copy link
Contributor Author

andy013 commented Sep 15, 2017

Oops, I changed it in photoshop but forgot to export before uploading.

Here's an alternative as well:


I also did these extra ones

heyLibs =
heyFas =

@DennisTheFinn
Copy link
Contributor

wanna make a veto one?

@andy013
Copy link
Contributor Author

andy013 commented Sep 15, 2017

@andy013
Copy link
Contributor Author

andy013 commented Sep 20, 2017

Hey, so I decided to have a go at implementing this. I put a branch up here if you want to check it out: https://github.com/andy013/secret-hitler/tree/emotes

It works fine, but since I'm very inexperienced with javascript I'm not sure if my implementation is the correct way to do it. I didn't know how to prevent the image links being escaped so I just used react to render the image tags. The only issue I had was the console keeps throwing up an error about them not having unique keys. Since they are emotes that will be reused I don't think it's possible to give them a unique key.

There's probably a much simpler way of doing it but I couldn't figure it out yet.

@cozuya
Copy link
Owner

cozuya commented Sep 20, 2017

Cool I can take a look (and the key thing is an easy thing to get around) but could you actually make a PR to this repo instead? Its a pain installing this thing :p

@andy013
Copy link
Contributor Author

andy013 commented Sep 20, 2017

Oh yeah, sure. I didn't know if it was appropriate to do a PR for something like this (that I'm not sure will be included in the main branch).

@cozuya
Copy link
Owner

cozuya commented Sep 20, 2017

Nah if we don't wind up using it no problem with it being here and closed.

@DennisTheFinn DennisTheFinn changed the title Add twitch.tv style emotes Request Emotes Sep 22, 2017
@DennisTheFinn DennisTheFinn added Living document Long-term issues intended to be continually edited and removed suggested enhancement Unapproved issues that could improve site features labels Sep 22, 2017
Repository owner deleted a comment from andy013 Sep 22, 2017
Repository owner deleted a comment from andy013 Sep 22, 2017
Repository owner deleted a comment from andy013 Sep 22, 2017
@DennisTheFinn
Copy link
Contributor

hey @andy013 no pressure but I would love to have more emotes! lmk what you think!

@DennisTheFinn
Copy link
Contributor

we need a CNH one!!!

@coolanybody
Copy link

I don't know how to make images but I'd personally love a thinking emote for all the stuff that really makes you think 🤔

@cozuya
Copy link
Owner

cozuya commented Dec 17, 2017

I like it but not sure about licensing. @DennisTheFinn if you want to make one (and a cnh one) I could get it in. or uh find an open source version.

@Cayseron
Copy link

Cayseron commented Feb 8, 2018

👍 ThumbsUp
🍿 PopCorn
and a CNH emoji......

@cozuya
Copy link
Owner

cozuya commented Feb 8, 2018

I can get that in

@Ophxlia
Copy link

Ophxlia commented Feb 9, 2018

a red loveheart!

@ghost
Copy link

ghost commented Mar 9, 2018

Hey @Peeps, I feel like I want to be on an emoji input stream for the site. Let me know if u have any ideas u want to see added and ill get them in pending on master coz's approval of course. All such emojis/emotes must be in compliance with the site and game rules. Feel free to PM me or to ping me any suggestions or images u have that ud like to see become an emote for the general lobby chat and the game chat. I recently made a pizza emoji to accompany what already exists. Hit me up! 😄

@ghost
Copy link

ghost commented Mar 9, 2018

PopCorn and RedHeart and ThinkFace and PIZZA what else? ;) hit me up @Lordvader#9988 - Discord https://discord.gg/secrethitlerio

@ghost
Copy link

ghost commented Mar 9, 2018

@coolanybody , @Cayseron , and @Ophxlia : I got the ThinkFace, PopCorn, and RedHeart emojis/emotes into the code as soon they are reviewed. by @cozuya .

@ghost
Copy link

ghost commented Mar 10, 2018

ExpressionlessFace is implemented @cozuya :D

@Max1071
Copy link
Contributor

Max1071 commented Apr 18, 2018

Need salt emote ASAP!

@ghost
Copy link

ghost commented Apr 18, 2018

Check! #785 ;)

@d4s0n
Copy link

d4s0n commented Apr 20, 2018

libs win!!! and fas win!!!! ple

@Lord-Zuko
Copy link
Contributor

we should have the ThumbsDown emoji as well lul

@Max1071
Copy link
Contributor

Max1071 commented May 11, 2018

duh HEIL! emote ofc
suggested by Buffel

@Lord-Zuko Lord-Zuko mentioned this issue Feb 25, 2019
@samfuller01
Copy link
Contributor

Honestly this doesn't seem to be used anymore. It could probably be closed. The last comment was almost a year ago.

@Max1071
Copy link
Contributor

Max1071 commented Feb 27, 2019

I have this issue tied to the Emote page on the wiki. I'd prefer to keep this open.

@samfuller01
Copy link
Contributor

Ok then we can keep it open @Max1071

@Lord-Zuko
Copy link
Contributor

Would like to suggest the addition of "LibPensive" (https://i.imgur.com/iGVRcB4.png) & "LibThink" (https://i.imgur.com/sya4HFU.png)

@Max1071
Copy link
Contributor

Max1071 commented Jul 7, 2019

EpicFlamingHitler

@evanmnjd
Copy link
Contributor

https://imgur.com/uvUJ9Qn

i dont think of it as "sleepy" but more like a sarcastic cry. its art. :)

@Vigasaurus
Copy link
Collaborator

Just copying over: #1467

@Mistery1307
Copy link

Alright, it'd be cool to have this emote, ChillOut, for when you get put in the freezer(Being put in the freezer means that you get locked out of elections, and get neined every time, most likely because of unresolved conflicts.)
ChillOut

@realDerekTan
Copy link

Consider adding these two emojis, the high elo players will love them.

NO RBB
WE WON

@Vigasaurus
Copy link
Collaborator

Yeah I like them quite a bit, as far as concept and implementation goes. I think they need some work to make them a bit more compacted to look good at 28x28 and maybe some for the rbb to make it more in line with the rest of the theme of the site (see top deck emote). I think the latter is very good, and if compacted should look great. (Both should also be transparentized)

@realDerekTan
Copy link

I think there's a way to transparentize both images, but at the size of 28x28, it shouldn't make that much of a difference. I didn't find the font for the TopDeck emote, so I decided to use a good looking font of my own. I think if you scale it down it shouldn't be that big of a problem. Perhaps test it with the sample images here and let me know if it needs further fixes?

@Vigasaurus
Copy link
Collaborator

Vigasaurus commented Jan 18, 2021

Yeah if you want to transparentized them, and scale them to 28 I can try them out/re-review. As for RBB, I think Germania One could look okay as a font (it's on Google Fonts) - but honestly after looking at yours a bit more, it's not bad.

@Lord-Zuko
Copy link
Contributor

there is, just slap em in paint.net and delet the background. the transparent background is just so if somebody has it set to a different background color it won't show up

@Lord-Zuko
Copy link
Contributor

W/a bit more modification you can make it say "no rrb"

@MontyMongo
Copy link

stealing my cardback and using it as an emote >:(

@Lord-Zuko
Copy link
Contributor

bababooey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Living document Long-term issues intended to be continually edited
Projects
None yet
Development

No branches or pull requests