Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Whitelist Players" UI for private games should be improved #1667

Open
nch0w opened this issue Jul 16, 2020 · 1 comment
Open

"Whitelist Players" UI for private games should be improved #1667

nch0w opened this issue Jul 16, 2020 · 1 comment
Labels
bug Issues that report a bug good for first timers Issues that are good for first-time contributors

Comments

@nch0w
Copy link
Contributor

nch0w commented Jul 16, 2020

image

  • Don't make it a giant modal - maybe a popup over the button would be better
  • Make it searchable?
  • Use Semantic UI instead of raw html

probably a low-priority issue, but still...
@nch0w nch0w added the bug Issues that report a bug label Jul 16, 2020
@Vigasaurus Vigasaurus added the good for first timers Issues that are good for first-time contributors label Jul 19, 2020
@maxschommer
Copy link

An additional issue with this seems to be that if you whitelist a player, and a new player signs up for an account, and then you check the whitelist, the checkbox for the whitelisted player is shifted up one index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that report a bug good for first timers Issues that are good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxschommer @nch0w @Vigasaurus