Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation claim impossible if investigation is completed before cards claim is done #1666

Open
2 of 6 tasks
RTRB1 opened this issue Jul 15, 2020 · 3 comments
Open
2 of 6 tasks
Labels
bug Issues that report a bug

Comments

@RTRB1
Copy link

RTRB1 commented Jul 15, 2020

Describe the bug

A player who investigates another player as president cannot claim their investigation if they did not claim the cards they drew before they investigated. Any attempt to claim the investigation must be done in the chat, notably important for silent games. While this would probably not happen to more experienced players, it has occasionally happened with less experienced players in silent games.

What does this issue relate to? Please put an X in the [ ] (i.e. turn [ ] into [X]) for the relevant choice.

  • Gameplay
  • User Interface
  • Game Modes
  • Mod Tools
  • Replays
  • Something Else: Please describe

To Reproduce
Steps to reproduce the behavior if any (Basically Necessary for issue to be fixed):

(Only known to exist in 7 player games, possibly exists in others)

  1. Have the 2nd fascist policy played but do not immediately claim the cards.

  2. Investigate another player (still do not claim).

  3. Complete the investigation animations, etc (I don't know if this is strictly required but is how it happened).

  4. Now when the claim is attempted, only the option to claim the cards is present and the claim for the investigation cannot be done at all.

@RTRB1 RTRB1 added the bug Issues that report a bug label Jul 15, 2020
@samueldashadrach
Copy link

samueldashadrach commented Jul 15, 2020

Oh my god, yes, this happens a lot.

Possible solutions

  1. player can make the inv only after claiming cards
  2. player can claim the inv only after claiming cards
  3. both claim options are visible simultaneously on screen (and can hence be used or avoided at will). This is probably more effort to code.

Note that the above will actually indicate minorly different rules of the game, so one has to decide which rule set to adopt. It might be useful for a player to hold up a claim on cards and make the inv first (option 2) - for instance if youre hitty and want more information yourself before deciding what to claim, or if youre lib fake confing to get reactions, or if youre a fas pretending to be a lib fake confing to get reactions, but actually creating chaos.

Regarding 3, I guess the question is whether claims are an optional addition to the game, or a necessary part of it. Should people have the right to not claim? (This question must be answered separately for both normal games and silent.) If no, it might a good idea to pause the game every time a claim is required on either cards or inv, this will reduce poor play by new players who sometimes rush on.

@RTRB1 RTRB1 changed the title Investigation claim impossible if investigation is attempted before cards claim is done Investigation claim impossible if investigation is completed before cards claim is done Jul 15, 2020
@RTRB1
Copy link
Author

RTRB1 commented Jul 15, 2020

A possible solution might be to make a "claim queue", similar to the idea 2. So in order to complete the inv claim you have to do the cards claim first. This might lead to slightly suboptimal gameplay but would probably make up for the lost information that the current problem leads to

@BeebieDuck
Copy link
Collaborator

I'm no geek here but in your 1st possible solution, you're forcing a player to claim the cards for the game to continue, if I'm reading it right? A player is not forced to claim if they don't want to claim so doing that beats the whole point of not being "forced to claim". Kinda the same thing applies to the 2nd solution.

The 3rd option is probably the best one there since it's giving you the option to not claim if you don't want to and also lets you claim cards and investigation role in case you didn't claim cards before investigating a player. Although I'm assuming the option to claim the cards and inv would also go away after the next government has been jaed (or however it currently goes away when someone doesn't claim)

Outside silent games though, you're also able to claim inv role by typing the role in the chat (like "lib" or "liberal" or something). so if the game is looking for a card claim but you're trying to claim the inv and not cards and it's not letting you, that might be a bit confusing. Although I'm not sure if this thing in particular is that big of an issue (or one at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that report a bug
Projects
None yet
Development

No branches or pull requests

3 participants