Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Make batch viewer tooltip persistent on mobile #116

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

ramirotw
Copy link
Contributor

@ramirotw ramirotw commented Jun 10, 2022

@coveralls
Copy link

coveralls commented Jun 10, 2022

Pull Request Test Coverage Report for Build 2495818773

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.872%

Totals Coverage Status
Change from base Build 2465584360: 0.0%
Covered Lines: 2162
Relevant Lines: 4177

💛 - Coveralls

@github-actions
Copy link

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
Just a question why was it necessary to use a removeListener just for the tapstart, and not use the one for the L188

@ramirotw ramirotw merged commit 01f2159 into develop Jun 14, 2022
@ramirotw ramirotw deleted the ramirotw/issue-43-batch-viewer-tooltips branch June 14, 2022 14:09
@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch viewer: tooltips are blinking when press on a token in a mobile view
4 participants