Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Kleros token list because it's too big #5217

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

Context: https://cowservices.slack.com/archives/C0361CDG8GP/p1734421577955559

Before:

allTokenListsInfoAtom:v4 5279.48046875 KB

After:

allTokenListsInfoAtom:v5 2361.544921875 KB

To Test

Change network many times, the app should not crash

@shoom3301 shoom3301 requested review from a team December 17, 2024 12:09
@shoom3301 shoom3301 self-assigned this Dec 17, 2024
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am
cowfi ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:09am

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we won't miss any of those tokens. It looks like that list is updated frequently

I randomly picked two, and they were not relevant, but maybe some are?

@shoom3301
Copy link
Collaborator Author

Are you sure we won't miss any of those tokens. It looks like that list is updated frequently

We 100% loose some tokens from this list (like you see on the picture). But since we have search using https://bff.barn.cow.fi/proxies/tokens we do not lose anything, people still can find and add them.

image

@anxolin
Copy link
Contributor

anxolin commented Dec 17, 2024

We 100% loose some tokens from this list (like you see on the picture). But since we have search using https://bff.barn.cow.fi/proxies/tokens we do not lose anything, people still can find and add them.

Technically I'm unsure if all tokens are included in BFF. We don't control the delegation to the API. Probably good to add an issue in BFF to add this token list to our future token search endpoint

@shoom3301 shoom3301 merged commit 745e17f into develop Dec 17, 2024
12 of 13 checks passed
@shoom3301 shoom3301 deleted the fix/remove-kleros-list branch December 17, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@shoom3301
Copy link
Collaborator Author

Technically I'm unsure if all tokens are included in BFF

BFF is just a proxy which uses Coingeck API

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants