feat(cow-fi): cache data and pages #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
shoom3301
force-pushed
the
hotfix/cowfi-cache
branch
from
5dcaead to
c11cfe8
Compare
|
Report too large to display inline |
alfetopito
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before I got to this solution, I did the refactoring from pages to app router: #5167. It also has a value, but in order to stop spending money in Vercel I decided to extract this fix as a hotfix.
Changes
DATA_CACHE_TIME_SECONDSfrom 5 min to 1 hourCache-Controlheader fro all pages (600 seconds)react-inlinesvgcacheCMSrequestsfetch()requestsNow in Vercel we see that cache is working:
To Test
cache-control: public, s-maxage=60, stale-while-revalidate=600header in response.svgfiles. After the page reloading there should not be so many.svgrequests