-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react@19 and next@15 #5147
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
"react-feather": "^2.0.10", | ||
"react-ga4": "^1.4.1", | ||
"react-helmet": "^6.1.0", | ||
"react-icons": "^5.2.1", | ||
"react-inlinesvg": "^3.0.1", | ||
"react-intersection-observer": "^9.10.1", | ||
"react-is": "18.2.0", | ||
"react-is": "19.0.0-rc-66855b96-20241106", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version was set automatically by codemod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! what is this witchery of codemod! did it really work out of the box?
@@ -275,7 +275,7 @@ | |||
"@types/node": "18.16.9", | |||
"@types/react-copy-to-clipboard": "^4.3.0", | |||
"@types/react-cytoscapejs": "^1.2.2", | |||
"@types/react-dom": "18.2.14", | |||
"@types/react-dom": "npm:[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feals like a strange change to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, codemod did this
Yes, I just ran the script and that is it ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shoom3301 , appdata page on Explorer is crashed
Same happens with User details page https://explorer-dev-git-feat-upgrade-core-deps-cowswap.vercel.app/base/address/0x9FA3c00a92Ec5f96B1Ad2527ab41B3932EFEDa58
Order [details ](https://explorer-dev-git-feat-upgrade-core-deps-cowswap.vercel.app/gc/orders/0x0fc45d51a9826b171364f54e59ee848fd697a7c9acd70796e75e27b6369b5a4d9fa3c00a92ec5f96b1ad2527ab41b3932efeda58674f0a6f?tab=overview)
and TX details
@elena-zh thank you! |
Hey @shoom3301 , batch graph page is still crashing |
Report too large to display inline |
@elena-zh fixed this one as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now!
The issue with 'reading h' is reported in #3636
Summary
All started from the Vercel costs issue.
I've found out that next@14 has issues with caching with causes the ISR Writes issues:
https://www.reddit.com/r/nextjs/comments/1gdguci/isr_writes_insanely_high/
next
to 15 using codemodreact
to 19 using codemodTo Test
Please make a sanity check of CoW Swap, Explorer and landings.
No need to test deeply, just go through all pages.