feat(volumeFee): add volume fee for Safe #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
approved these changes
Nov 29, 2024
| */ | ||
| export const safeAppFeeAtom = atom<VolumeFee | null>((get) => { | ||
| const { chainId } = get(walletInfoAtom) | ||
| const { isSafeApp } = get(walletDetailsAtom) |
There was a problem hiding this comment.
will this affect also wallet connect, or just the safe app?
elena-zh
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Hey @shoom3301 , great, but:
- Fee breakdowns are not working. No matter which amount to sell I select. the min fee size is applied to a trade
- It would be nice to remove intends in this tooltip (we don't have them in other tooltips)
- It would be great to add a feature flag for this feature
- Question: We are loosing our internal fees on Arb and GC. (0.1%). Are we OK with this?
- Should we rename this fee inside the AppData (discussion)?
elena-zh
approved these changes
Nov 29, 2024
|
I've done one more test round: everything works great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reference: https://help.safe.global/en/articles/178530-how-does-the-widget-fee-work-for-native-swaps
Basically, CoW Swap should work the same with https://app.safe.global/swap when it is open in Safe Apps.
I literally copy-pasted the logic from Safe frontend.
The only thing that might be different is stablecoins list. We have our own list, our list at least matches mainnet (USDC/USDT/DAI).
To Test
Volume fee should work exactly the same with https://app.safe.global/swap