feat: improve custom hook validation messages #5123
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hey @fairlighteth , sorry to tell you this, but something is not working as expected here:
- I'm not able to open a hook that is running locally:
- When I'm adding https://cow-hooks-dapps-cow-amm-deposit.vercel.app hook link (it is a valid link), the app says that it is blocked by CORS issues
- Some working validations gone missing:
- post-pre hooks
- chain:
- wallet support:
Could you please take a look at all these issues?
…ap into custom-hook-validation
|
@elena-zh could you try again? The only case I couldn't simulate on my end was the 'wrong chain' scenario. The others seemed correct now. |
| }, options.timeout) | ||
|
|
||
| try { | ||
| const response = await fetch(url, { signal: controller.signal, ...options }) |
There was a problem hiding this comment.
Please, use existing getTimeoutAbortController() from @cowprotocol/common-utils
There was a problem hiding this comment.
Thanks for reviewing. Addressed this now.
…ap into custom-hook-validation
| @@ -0,0 +1,23 @@ | |||
| import { getTimeoutAbortController } from '@cowprotocol/common-utils' | |||
There was a problem hiding this comment.
I was suggesting to move it to @cowprotocol/common-utils, you might want to use this in other front-ends and not just CoW Swap. Anyways, we can always move when needed in other apps if this is adding some overhead
There was a problem hiding this comment.
@anxolin I see now it was added to the common-utils but didn't cleanup the older util function. Just pushed a fix for this now.
Summary