Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(limit-orders): do not crash when sell amount is giant #5120

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

Fixes #5110

  1. Added a condition in order to avoid price calculation when sell amount is enormuosly big to avoid app crashing
  2. Limited amount input with 32 chars (it was 79 since 2020)

To Test

See #5110

@shoom3301 shoom3301 requested review from a team November 21, 2024 09:07
@shoom3301 shoom3301 self-assigned this Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 21, 2024 9:14am
cowfi ✅ Ready (Inspect) Visit Preview Nov 21, 2024 9:14am
explorer-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2024 9:14am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2024 9:14am
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 21, 2024 9:14am

@elena-zh
Copy link
Contributor

Thank you!

@shoom3301 shoom3301 merged commit 94d71f1 into develop Nov 21, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the fix/5110 branch November 21, 2024 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit: The app crashed when quote for a huge amount of a token
2 participants