Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.44]Expired parts turn to Cancelled when cancel the last part #3007

Closed
elena-zh opened this issue Aug 4, 2023 · 1 comment
Closed

[1.44]Expired parts turn to Cancelled when cancel the last part #3007

elena-zh opened this issue Aug 4, 2023 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Aug 4, 2023

Reported in #2987 (review) (case 2)

  1. Place a TWAP order with 3 parts, select WETH token to sell
  2. Once the order is placed, remove WETH token balance from the Safe account (unwrap WETH)
  3. Wait till 2 parts expire due to insufficient balance
  4. When the 2nd part expires, return WETH balance to the Safe account
  5. When the 3rd part goes to Open, run cancel part transaction

AR: 2 expired parts' statuses are changed to 'Cancelled'
image.png

In the end the 2 Expired parts are recorded as Cancelled, and the one Cancelled part is recorded as Expired
image.png
ER: statuses remain Expired

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP labels Aug 4, 2023
@elena-zh
Copy link
Contributor Author

No longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP
Projects
None yet
Development

No branches or pull requests

1 participant