Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to set handler the 2nd time (until clear out local storage) #2949

Closed
elena-zh opened this issue Jul 27, 2023 · 1 comment
Closed
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP

Comments

@elena-zh
Copy link
Contributor

Related to #2938

It is an edge case. I hope that no one will face this ever.

  1. Open a Safe account that has not setup a handler
  2. Place a TWAP order and Set fallback handler in TWAP
  3. Then follow instructions in chore(twap): testing tool to reset fallback handler #2658 to reset the handler
  4. Return back to the app and place one more TWAP order

AR: there is no warning to set the handler the 2nd time. TWAP order is placed, but parts are not created there.
If clear out the local storage, the app will show the warning to set up the handler

ER: the warning to set up the handler for the 2nd time should appear

Assumptions: might be the case when the 1st transaction is cancelled/failed in the Safe.

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP labels Jul 27, 2023
@elena-zh elena-zh changed the title Impossible to set a handler the 2nd time (until clear out a local storage) Impossible to set handler the 2nd time (until clear out local storage) Jul 27, 2023
@elena-zh
Copy link
Contributor Author

Closing: no users' complaints on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP
Projects
None yet
Development

No branches or pull requests

1 participant