Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app is crashed when type in 34,34 into the Slippage field #2832

Closed
elena-zh opened this issue Jul 10, 2023 · 1 comment · Fixed by #2835
Closed

The app is crashed when type in 34,34 into the Slippage field #2832

elena-zh opened this issue Jul 10, 2023 · 1 comment · Fixed by #2835
Assignees
@alfetopito
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP

Comments

@elena-zh
Copy link
Contributor

  1. Open Advanced orders page
  2. Type 34.34 into the Slippage field

AR: the app is crashed
image.png
ER: the app is not crashed.
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP labels Jul 10, 2023
@elena-zh
Copy link
Contributor Author

Also reported in #2797 (review)

@alfetopito alfetopito mentioned this issue Jul 10, 2023
Merged
@alfetopito alfetopito self-assigned this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfetopito alfetopito

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(twap): fix slippage value crash cowprotocol/cowswap
2 participants
@alfetopito @elena-zh