Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowiseai: corrections/ additions to helm chart #722

Closed
danielstankw opened this issue Aug 28, 2024 · 4 comments
Closed

Flowiseai: corrections/ additions to helm chart #722

danielstankw opened this issue Aug 28, 2024 · 4 comments

Comments

@danielstankw
Copy link

Hi,

  1. In case a service of type LoadBalancer is chosen, in the template the NodePort is required, why is that? - would it be possible to remove this dependency?
  2. Would you be able to add host aliases to the helm chart?
    deployment.yaml
    spec:
      hostAliases:
        {{- toYaml .Values.hostAliases | nindent 8 }}

and then values.yaml

extraDeploy: []

## @section Parameters

## @param replicaCount Number of replicas (do not change it)
replicaCount: 1

hostAliases:
- ip: "XXXX"
  hostnames:
  - "XXXXX"
@danielstankw
Copy link
Author

@sebastien-prudhomme

@sebastien-prudhomme
Copy link
Contributor

@danielstankw

  1. The node port is dynamic by default. I think it's mandatory to have a port on the node to allow the load balancing mode. How the external load balancer could contact the service without this node port?

  2. I will add it in next version

@sebastien-prudhomme
Copy link
Contributor

Fixed by #724

@danielstankw
Copy link
Author

Thank you ! @sebastien-prudhomme
Regarding the first point.
Its mandatory to use NodePort, but it is automatically managed by Kubernetes, and it will be automatically allocated if not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants